Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 60 tests now pass with
bun test. Before this change, 16 failed.dividenow throws on a zero divisor.wordCountnow handles several spaces in a row.truncateis implemented: it cuts at a word boundary and adds....remove,updateandsortByare implemented.formatRelativenow rounds the day count instead of truncating it, the same way for past and future dates.isEmailaccepts long top-level domains.isUrlaccepts URLs with a port.Assumptions: changes are limited to what the tests need. Test files were not changed and no dependencies were added.
Known limitations (not covered by tests, left unchanged):
truncatereturns...whenmaxLengthis less than 3, so the result can be longer thanmaxLength.updatecopies every key it is given, so an explicitundefinedcan overwrite fields such astitle.Reviewed twice, the second time after the follow-up change. No blocking issues.